Jump to content

Server

What‽ More suggestions‽

Started by taroshixela , Oct 05 2016 06:53 AM


  • Please log in to reply
4 replies to this topic

#1

taroshixela
  • taroshixela
  • Witch/Wizard
  • Student
  • 84 posts
  • IGN:Taro [taroshixela] Chambers

I know I just made a suggestion thread, but why not make more?

 

Server Icon

 

  • Having a server icon makes it seem more unique for new joiners.
  • It makes the server easy to identify in the server list.
  • It just looks cool.
  • Could be designed by players via a competition.

Skyblock Edits

 

  • Being able to edit your island settings (allowing visitors to harm mobs ect)
  • Island creation contest? (Making own schematics instead of the ones that come with it.
  • Fix the bettershops :3

  • 0

#2

Crane
  • Crane
  • Chief of the Wizards Council
  • Administrators
  • 743 posts
  • IGN:Liam Blishwick

I made an icon a little while back but everyone seemed to ignore it :P
Bettershops in skyblock are completely jacked up, I tried fixing them and they worked for "buying stuff" untill a restart I assume. Selling for gallons is still jacked and will be untill it too is fixed for main world :P
  • 0

#3

Pandette
  • Pandette
  • Special Advisor to the Wizengamot
  • Administrators
  • 2648 posts
  • IGN:iarepandemonium

Bettershops is not a suggestion.  It has been on the table for ever and if you had any idea how horrible the code for bettershops is the nyou would realize why: ie:

 

boolean c = true;

        if (shopItem.isTransCooldown()) {
            if (a > 0) {
                if (Cooldowns.canTransaction(p, shopItem, (int) a)) {
                    if (a < shopItem.getAmount()) {
                        c = false;
                        if (shopItem.getStock() > 0 && shopItem.getAmount() <= shopItem.getStock() && Core.getEconomy().getBalance(Bukkit.getOfflinePlayer(p.getUniqueId())) >= shopItem.getPrice() || shopItem.isInfinite() && Core.getEconomy().getBalance(Bukkit.getOfflinePlayer(p.getUniqueId())) >= shopItem.getPrice()) {
                            inv.setItem(18, limit);
                            inv.setItem(19, limit);
                        } else {
                            if (Core.getEconomy().getBalance(Bukkit.getOfflinePlayer(p.getUniqueId())) < shopItem.getPrice()) {
                                inv.setItem(18, enough);
                                inv.setItem(19, enough);
                            } else {
                                if (!shopItem.isInfinite()) {
                                    inv.setItem(18, enough2);
                                    inv.setItem(19, enough2);
                                } else {
                                    inv.setItem(18, limit);
                                    inv.setItem(19, limit);
                                }
                            }
                        }
                    } else {
                        c = true;
                    }
                } else {
                    c = false;
                    inv.setItem(18, enough4);
                    inv.setItem(19, enough4);
                }
            } else {
                c = false;
                inv.setItem(18, enough4);
                inv.setItem(19, enough4);
            }
        }

        if © {
            if (Core.getEconomy().hasAccount(Bukkit.getOfflinePlayer(p.getUniqueId())) && Core.getEconomy().hasAccount(shop.getOwner())) {
                if (shopItem.getStock() > 0 && shopItem.getAmount() <= shopItem.getStock() && Core.getEconomy().getBalance(Bukkit.getOfflinePlayer(p.getUniqueId())) >= shopItem.getPrice() || shopItem.isInfinite() && Core.getEconomy().getBalance(Bukkit.getOfflinePlayer(p.getUniqueId())) >= shopItem.getPrice()) {
                    inv.setItem(18, buy);
                    inv.setItem(19, buy);
                } else {
                    if (Core.getEconomy().getBalance(Bukkit.getOfflinePlayer(p.getUniqueId())) < shopItem.getPrice()) {
                        inv.setItem(18, enough);
                        inv.setItem(19, enough);
                    } else {
                        if (!shopItem.isInfinite()) {
                            inv.setItem(18, enough2);
                            inv.setItem(19, enough2);
                        } else {
                            inv.setItem(18, buy);
                            inv.setItem(19, buy);
                        }
                    }
                }
            } else {
                inv.setItem(18, enough3);
                inv.setItem(19, enough3);
            }
        }

        inv.setItem(25, cancel);
inv.setItem(26, cancel);

 

 

^^^ I have to fix horribly coded stuff like this that have no comments and no information about what they are and are poorly structured.

 

If you remember why I stressed so highly to check if something wasnt and return THIS HORRIBLE THING IS WHY


  • 0

#4

Pandette
  • Pandette
  • Special Advisor to the Wizengamot
  • Administrators
  • 2648 posts
  • IGN:iarepandemonium

also fyi, this is what is looked like cleaned up:

 

inv.setItem(4, (ItemStack) obj[0]);

        ItemStack result = null;

        if (cooldownAmount > 0 || !Cooldowns.canTransaction(p, shopItem, (int) cooldownAmount)) {
            result = enough4;
        }

        if (result == null && !new Wallet(p, (int) shopItem.getPrice()).canAfford()) {
            result = enough;
        }

        if (result == null && shopItem.getStock() < 0 && !shopItem.isInfinite()) {
            result = enough2;
        }

        if (result == null) {
            result = buy;
        }


        inv.setItem(18, result);
        inv.setItem(19, result);

        inv.setItem(25, cancel);
        inv.setItem(26, cancel);


  • 1

#5

Pandette
  • Pandette
  • Special Advisor to the Wizengamot
  • Administrators
  • 2648 posts
  • IGN:iarepandemonium

@Crane have an icon creation contest.


  • 0



Also tagged with one or more of these keywords: Server

0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users